KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol #18600

frankvicky · 2025-01-17T16:08:12Z

JIRA: KAFKA-18561
Remove withKip853Rpc and replace it with withRaftProtocol and adjust the corresponding test.

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

frankvicky · 2025-01-17T16:09:10Z

Hi @ahuang98
Please take a look when you have a free cycle.
Many thanks 🙇🏼

ijuma · 2025-01-22T02:37:06Z

@jsancio You're ok with this?

github-actions · 2025-01-25T03:06:30Z

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

github-actions · 2025-01-27T03:08:40Z

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

github-actions · 2025-01-30T03:07:20Z

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

ahuang98 · 2025-01-31T16:37:08Z

@ijuma I introduced withRaftProtocol and believe @jsancio is okay with this change. I'll review first

ahuang98

With this change it's more obvious that KafkaRaftClientTest only covers KIP_853_PROTOCOL and lower, I wonder if it would be worth doing one of the following

have KafkaRaftClientTest test the whole range of RaftProtocols
replace KIP_853_PROTOCOL with latestProtocol() which will pick the last enum constant in RaftProtocol, and KafkaRaftClientTest will always test the newest protocol
java doc / rename for KafkaRaftClientTest to indicate this only covers a subset of the raft protocols

ahuang98 · 2025-01-31T16:40:46Z

raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java

        }
    }
+
+    private boolean isSupport853(RaftProtocol raftProtocol) {


you can use RaftClientTestContext.isReconfigSupported()

Thanks.
I don't notice that we have such a helper method.

ahuang98 · 2025-01-31T16:46:31Z

raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java

+    private static final String KIP_595_PROTOCOL = "KIP_595_PROTOCOL";
+    private static final String KIP_853_PROTOCOL = "KIP_853_PROTOCOL";


my slight pref would be to remove these and just use the strings directly in the EnumSource annotations

suggestion should also be applied to KafkaRaftClientTest if you agree

ahuang98 · 2025-01-31T16:53:10Z

raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java

-    @CsvSource({ "false,false", "false,true", "true,false", "true,true" })
-    public void testLeaderListenerNotified(boolean entireLog, boolean withKip853Rpc) throws Exception {
+    @MethodSource("generateKip853TestMatrix")
+    public void testLeaderListenerNotified(boolean entireLog, RaftProtocol raftProtocol) throws Exception {


I guess another option would be just renaming the second parameter to boolean isReconfigSupported, potentially easier for readers to know at a glance that we're not testing the entire set of raftProtocols (rather than navigating to the method source definition)

(then we would do .withRaftProtocol(isReconfigSupported ? KIP_853_PROTOCOL : KIP_595_PROTOCOL) which I understand is a bit bulkier)

ahuang98 · 2025-01-31T16:55:12Z

raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java

-        ReplicaKey voter1 = replicaKey(localId + 1, withKip853Rpc);
-        ReplicaKey voter2 = replicaKey(localId + 2, withKip853Rpc);
-        ReplicaKey observer3 = replicaKey(localId + 3, withKip853Rpc);
+        boolean support853 = isSupport853(raftProtocol);


nit: support853 -> reconfigSupported

was this change applied everywhere? we should remove isSupport853() since it's a dupe of reconfigSupported()

Hi @ahuang98
Sorry for inconvience. Previously, I had a finger issue when rebasing.
Now all comments should be applied. PTAL

there was no inconvenience 😅 sorry to hear about your finger! I missed your update today and will review tomorrow morning

Thank you 😆

frankvicky · 2025-04-18T03:47:35Z

Hi @jsancio
Since this patch changes the base logic of the test, it would be painful when conflicts happen.
Could you please take a look when you have a free moment?

Many thanks!

github-actions · 2025-07-21T03:56:08Z

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions · 2025-08-21T03:43:57Z

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

github-actions bot added triage PRs from the community tests Test fixes (including flaky tests) kraft labels Jan 17, 2025

chia7712 added the ci-approved label Jan 17, 2025

frankvicky force-pushed the KAFKA-18561 branch from 2d4e93d to aaaab78 Compare January 18, 2025 01:25

ijuma requested a review from jsancio January 18, 2025 13:39

frankvicky force-pushed the KAFKA-18561 branch 2 times, most recently from c36f9bc to 312c113 Compare January 21, 2025 02:29

jsancio self-assigned this Jan 22, 2025

frankvicky force-pushed the KAFKA-18561 branch from 312c113 to d943da8 Compare January 24, 2025 07:51

github-actions bot added the needs-attention label Jan 25, 2025

frankvicky force-pushed the KAFKA-18561 branch 2 times, most recently from b93875b to fabd9f6 Compare January 26, 2025 02:04

github-actions bot removed the needs-attention label Jan 26, 2025

github-actions bot added the needs-attention label Jan 27, 2025

frankvicky force-pushed the KAFKA-18561 branch 2 times, most recently from 4e56589 to 543467d Compare January 29, 2025 02:55

github-actions bot removed the needs-attention label Jan 29, 2025

github-actions bot added the needs-attention label Jan 30, 2025

frankvicky force-pushed the KAFKA-18561 branch 2 times, most recently from e135aed to 826ba56 Compare January 31, 2025 07:42

ahuang98 suggested changes Jan 31, 2025

View reviewed changes

github-actions bot removed needs-attention triage PRs from the community labels Feb 1, 2025

frankvicky added 21 commits March 23, 2025 15:45

Merge branch 'trunk' into KAFKA-18561

efc2b18

Merge branch 'trunk' into KAFKA-18561

41562b0

Merge branch 'trunk' into KAFKA-18561

6c28109

Merge branch 'trunk' into KAFKA-18561

2c34597

Merge branch 'trunk' into KAFKA-18561

23825e0

Merge branch 'trunk' into KAFKA-18561

90bcc3e

Merge branch 'trunk' into KAFKA-18561

f8899ae

Merge branch 'trunk' into KAFKA-18561

5138e1b

Merge branch 'trunk' into KAFKA-18561

04951ad

fix conflicts

b6a7e47

Merge branch 'trunk' into KAFKA-18561

5b5d856

Merge branch 'trunk' into KAFKA-18561

b274ff7

Merge branch 'trunk' into KAFKA-18561

29b8f81

Merge branch 'trunk' into KAFKA-18561

0b5c992

Merge branch 'trunk' into KAFKA-18561

52a4d57

Merge branch 'trunk' into KAFKA-18561

70ab047

Merge branch 'trunk' into KAFKA-18561

abfb9a9

Merge branch 'trunk' into KAFKA-18561

38ee31e

Merge branch 'trunk' into KAFKA-18561

e48acee

Merge branch 'trunk' into KAFKA-18561

c5c7117

fix conflicts

7f95aa1

frankvicky requested a review from jsancio April 18, 2025 03:45

frankvicky added 2 commits April 20, 2025 16:51

Merge branch 'trunk' into KAFKA-18561

8f6088b

Merge branch 'trunk' into KAFKA-18561

0d6185e

github-actions bot added the stale Stale PRs label Jul 21, 2025

github-actions bot added the closed-stale PRs that were closed due to inactivity label Aug 21, 2025

github-actions bot closed this Aug 21, 2025

		private static final String KIP_595_PROTOCOL = "KIP_595_PROTOCOL";
		private static final String KIP_853_PROTOCOL = "KIP_853_PROTOCOL";

Uh oh!

KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol #18600

KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol #18600

Uh oh!

Conversation

frankvicky commented Jan 17, 2025

Committer Checklist (excluded from commit message)

Uh oh!

frankvicky commented Jan 17, 2025

Uh oh!

ijuma commented Jan 22, 2025

Uh oh!

github-actions bot commented Jan 25, 2025

Uh oh!

github-actions bot commented Jan 27, 2025

Uh oh!

github-actions bot commented Jan 30, 2025

Uh oh!

ahuang98 commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahuang98 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahuang98 Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frankvicky commented Apr 18, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ahuang98 commented Jan 31, 2025 •

edited

Loading

ahuang98 Mar 5, 2025 •

edited

Loading