KAFKA-18660: Transactions Version 2 doesn't handle epoch overflow correctly #18730
+97
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
jolshan
added
Blocker
| @@ -408,13 +408,13 @@ class TransactionCoordinator(txnConfig: TransactionConfig, | |||
|
|
|||
| // generate the new transaction metadata with added partitions | |||
| txnMetadata.inLock { | |||
| if (txnMetadata.producerId != producerId) { | |||
| if (txnMetadata.pendingTransitionInProgress) { | |||
| // return a retriable exception to let the client backoff and retry | |||
There was a problem hiding this comment.
Can we add a comment here that explains the significance of ordering this check prior to others?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the typo that used the wrong producer ID and epoch when returning so that we handle epoch overflow correctly.
We also had to rearrange the concurrent transaction handling so that we don't self-fence when we start the new transaction with the new producer ID.
I also tested this with a modified version of the code where epoch overflow happens on the first epoch bump (every request has a new producer id)