KAFKA-17261: Support to create a quorum controller which is not in cluster #18799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2b48b8d.
TaiJuWu
changed the title
TaiJuWu
commented
Feb 4, 2025
Comment on lines
+97
to
99
| // This matches URIs of formats: host:port | ||
| // IPv6 is supported with [ip] pattern | ||
| private static final Pattern HOST_PORT_PATTERN = Pattern.compile("^(?:[0-9a-zA-Z\\-%._]*://)?\\[?([0-9a-zA-Z\\-%._:]*)]?:([0-9]+)"); |
There was a problem hiding this comment.
This pattern easy make breaking change so I don't touch this one.
By the way, there is similar RE within
kafka/server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java
Lines 175 to 176 in d0bca67
Maybe we can unify them in 5.0.
TaiJuWu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-17261
This PR only support isolated controller to simply implementation.
Committer Checklist (excluded from commit message)