MINOR: Fix Some Exceptions in MetaPropertiesEnsemble and MetadataQuorumCommand #18957
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
jsancio
reviewed
Feb 21, 2025
Comment on lines
269
to
275
| "\nLeaderId: " + quorumInfo.leaderId() + | ||
| "\nLeaderEpoch: " + quorumInfo.leaderEpoch() + | ||
| "\nHighWatermark: " + quorumInfo.highWatermark() + | ||
| "\nMaxFollowerLag: " + maxFollowerLag + | ||
| "\nMaxFollowerLagTimeMs: " + maxFollowerLagTimeMs + | ||
| "\nCurrentVoters: " + printVoterState(quorumInfo) + | ||
| "\nCurrentObservers: " + printObserverState(quorumInfo) | ||
| "\nLeaderId: " + quorumInfo.leaderId() + | ||
| "\nLeaderEpoch: " + quorumInfo.leaderEpoch() + | ||
| "\nHighWatermark: " + quorumInfo.highWatermark() + | ||
| "\nMaxFollowerLag: " + maxFollowerLag + | ||
| "\nMaxFollowerLagTimeMs: " + maxFollowerLagTimeMs + | ||
| "\nCurrentVoters: " + printVoterState(quorumInfo) + | ||
| "\nCurrentObservers: " + printObserverState(quorumInfo) |
There was a problem hiding this comment.
This indentation doesn't look correct. We indent Java code using 4 spaces.
| @@ -404,16 +404,16 @@ static Set<RaftVoterEndpoint> getControllerAdvertisedListeners( | |||
| } | |||
| LinkedHashSet<RaftVoterEndpoint> results = new LinkedHashSet<>(); | |||
| for (String listenerName : props.getProperty( | |||
| KRaftConfigs.CONTROLLER_LISTENER_NAMES_CONFIG).split(",")) { | |||
| KRaftConfigs.CONTROLLER_LISTENER_NAMES_CONFIG).split(",")) { | |||
There was a problem hiding this comment.
How about this indentation and formatting so that the for loop statement block is clearly separated from the for loop iterable.
for (String listenerName : props.getProperty(
KRaftConfigs.CONTROLLER_LISTENER_NAMES_CONFIG).split(",")
) {
Comment on lines
415
to
416
| endpoint.host() == null ? "localhost" : endpoint.host(), | ||
| endpoint.port())); |
There was a problem hiding this comment.
How about this formatting?
results.add(
new RaftVoterEndpoint(
endpoint.listenerName().get(),
endpoint.host() == null ? "localhost" : endpoint.host(),
endpoint.port()
)
);
chia7712
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a minor PR to remove some unneeded exceptions and make Exceptions more specific.
Committer Checklist (excluded from commit message)