KAFKA-18827: Initialize share state, share coordinator impl. [1/N] #18968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
smjn
changed the title
AndrewJSchofield
requested changes
Feb 21, 2025
| topicPartitionFor(coordinatorKey), | ||
| Duration.ofMillis(config.shareCoordinatorWriteTimeoutMs()), | ||
| coordinator -> coordinator.initializeState(requestForCurrentPartition) | ||
| ).exceptionally(deleteException -> |
There was a problem hiding this comment.
nit: initializeException?
| List<InitializeShareGroupStateResponseData.PartitionResult> partitionResults = new ArrayList<>(topicEntry.size()); | ||
| topicEntry.forEach( | ||
| (partitionId, responseFuture) -> { | ||
| // ResponseFut would already be completed by now since we have used |
There was a problem hiding this comment.
The variable name was different in the code you copied here :)
| )) | ||
| )) | ||
| ); | ||
| WriteShareGroupStateResponseData responseData = new WriteShareGroupStateResponseData().setResults( |
There was a problem hiding this comment.
I think the previous style of
new WriteShareGroupStateResponse()
.setResults(
was more in line with the rest of the code you've written.
There was a problem hiding this comment.
It will need to be changed to as older style causes bad alignment. I have a JIRA for the same.
AndrewJSchofield
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we have added the share coordinator and KafkaApis side impl of the intialize share group state RPC.
ref: https://cwiki.apache.org/confluence/display/KAFKA/KIP-932%3A+Queues+for+Kafka#KIP932:QueuesforKafka-InitializeShareGroupStateAPI