KAFKA-19454: Handle topics missing in metadata in share delete. #20090
+303
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smjn
added
KIP-932
AndrewJSchofield
approved these changes
Jul 3, 2025
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 3, 2025
…he#20090) * There are instances where share group delete calls in group coordinator (`onPartitionsDelete`, `deleteShareGroups`) where we lookup the metadata image to fetch the topic id/partitions/topic name for a topic name/id. However, there have been instances where the looked up info was not found due to cluster being under load or the underlying topic being deleted and information not propagated correctly. * To remedy the same, this PR adds checks to determine that topic is indeed present in the image before the lookups thus preventing NPEs. The problematic situations are logged. * New tests have been added for `GroupMetadataManger` and `GroupCoordinatorService`. Reviewers: Andrew Schofield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coordinator (
onPartitionsDelete,deleteShareGroups) where we lookupthe metadata image to fetch the topic id/partitions/topic name for a
topic name/id. However, there have been
instances where the looked up info was not found due to cluster being
under load or the underlying topic being deleted and information not
propagated correctly.
indeed present in the image before the lookups thus preventing NPEs. The
problematic situations are logged.
GroupMetadataMangerandGroupCoordinatorService.Reviewers: Andrew Schofield [email protected]