[Experimental] Add rewrite support for RemoveUnusedPrivateMethods & RemoveUnusedImports
#20219
+80
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Pankraz76
commented
Jul 22, 2025
Pankraz76
commented
Jul 22, 2025
| @@ -1,7 +1,7 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionSha256Sum=845952a9d6afa783db70bb3b0effaae45ae5542ca2bb7929619e8af49cb634cf | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.1-bin.zip | |||
There was a problem hiding this comment.
does dependabot not check for this?
| id "com.github.spotbugs" version '6.0.25' apply false | ||
| id 'org.scoverage' version '8.0.3' apply false | ||
| id 'com.gradleup.shadow' version '8.3.6' apply false | ||
| id 'com.diffplug.spotless' version "6.25.0" |
There was a problem hiding this comment.
does dependabot not check for this?
… & `RemoveUnusedImports`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs:
rewritesupport forRemoveUnusedPrivateMethods&RemoveUnusedImportsopensearch-project/OpenSearch#18791The code seems to be out of sync considering large changes occurred when actually applying the config/convention:
(Assuming the version bump alone did not make these changes in the headers)
Also assuming that Java files currently have no header check besides Checkstyle. It seems considerable to have the Spot config in one place, giving it Separation of Concerns as well as Single Source of Truth. The file, considering it's over 2k LOC, is complex and hard to handle.
Doing this infrastructure topic repeatedly, I can tell that other projects have simpler configurations, despite possibly having even more in total, forcing them to adopt such a dedicated approach. Still, it's nice to see this project having a good foundation for good developer experience.