Skip to content

Conversation

lucliu1108
Copy link
Contributor

@lucliu1108 lucliu1108 commented Jul 30, 2025

Integration tests for Stream Admin related API

Previous PR: #20244

This one adds:

  • Integration test for Admin#listStreamsGroupOffsets API
  • Integration test for Admin#deleteStreamsGroupOffsets API
  • Integration test for Admin#alterStreamsGroupOffsets API

Reviewers: Alieh Saeedi [email protected], Lucas Brutschy
[email protected]

@github-actions github-actions bot added triage PRs from the community core Kafka Broker build Gradle build or GitHub Actions labels Jul 30, 2025
@mjsax mjsax added ci-approved streams admin AdminClient tests Test fixes (including flaky tests) and removed triage PRs from the community core Kafka Broker labels Aug 1, 2025
@github-actions github-actions bot added the core Kafka Broker label Aug 2, 2025
@aliehsaeedii
Copy link
Contributor

aliehsaeedii commented Aug 4, 2025

Thanks @lucliu1108
it's a high level review.
Please either add tests or modify the existing tests to test listing streams groups as well.


@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedGroupProtocolNames)
@MethodSource(Array("getTestGroupProtocolParametersStreamsGroupProtocolOnly"))
def testDescribeStreamsGroups(groupProtocol: String): Unit = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was in the previous PR! Duplicate!


@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedGroupProtocolNames)
@MethodSource(Array("getTestGroupProtocolParametersStreamsGroupProtocolOnly"))
def testDeleteStreamsGroups(groupProtocol: String): Unit = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here!

Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucasbru lucasbru changed the title KAFKA-19565 Integration test for Streams-related Admin APIs[2/N] KAFKA-19565: Integration test for Streams-related Admin APIs [2/N] Sep 4, 2025
@lucasbru lucasbru self-assigned this Sep 4, 2025
@lucasbru lucasbru merged commit f6f5b4c into apache:trunk Sep 9, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin AdminClient build Gradle build or GitHub Actions ci-approved core Kafka Broker streams tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants