KAFKA-19666: Remove old restoration codepath from SmokeTestDriverIntegrationTest [3/N] #20465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the SmokeTestDriverIntegrationTest by removing the state updater configuration parameter from the parameterized test. The change simplifies the test by removing the stateUpdaterEnabled parameter and its corresponding test cases, reducing the test matrix from 6 combinations to 4.
- Removes
stateUpdaterEnabledparameter from the parameterized test method - Updates the
@CsvSourceannotation to remove test cases that included the state updater parameter - Removes the
STATE_UPDATER_ENABLEDconfiguration from the test properties
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
118
to
121
| public void shouldWorkWithRebalance( | ||
| final boolean stateUpdaterEnabled, | ||
| final boolean processingThreadsEnabled, | ||
| final boolean streamsProtocolEnabled | ||
| ) throws InterruptedException { |
There was a problem hiding this comment.
The method signature and parameter documentation should be updated to reflect the removal of the stateUpdaterEnabled parameter. Consider updating any existing JavaDoc comments to accurately describe the current test parameters.
lucasbru
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up
SmokeTestDriverIntegrationTestReviewers: Lucas Brutschy [email protected]