MINOR: Add 4.1.0 to streams system tests #20480
Conversation
mimaison
force-pushed
the
41-streams-system-tests
branch
from
dd9dd52 to
126a4dc
Compare
| * Config value for parameter {@link #UPGRADE_FROM_CONFIG "upgrade.from"} for upgrading an application from version {@code 4.1.x}. | ||
| */ | ||
| @SuppressWarnings("WeakerAccess") | ||
| public static final String UPGRADE_FROM_41 = UpgradeFromValues.UPGRADE_FROM_41.toString(); |
There was a problem hiding this comment.
Should we also add UPGRADE_FROM_41 to UPGRADE_FROM_DOC accordingly?
There was a problem hiding this comment.
I guess, probably 😅
I copied 1ded681 which did not add 4.0 to that doc string.
There was a problem hiding this comment.
@lucasbru we need the Streams expert to provide the answer 😆
There was a problem hiding this comment.
Yes, I think we should add it there as well.
There was a problem hiding this comment.
Ok I'll follow up with a PR. Thanks!
There was a problem hiding this comment.
Actually we should delete the Accepted values are ... from the description. The config is defined with a Validator so we already print the valid values in the docs: https://kafka.apache.org/documentation/#streamsconfigs_upgrade.from
3 participants
This PR updates all the streams system tests to include 4.1.0.
Reviewers: Lucas Brutschy [email protected]