MINOR: Followup KAFKA-19112 document updated #20492
Conversation
m1a2st
changed the title
github-actions
bot
added
storage
docs/upgrade.html
Outdated
| local log segments will be cleaned based on the values of <code>log.local.retention.bytes</code> and | ||
| <code>log.local.retention.ms</code>. | ||
| <br> | ||
| Note that <code>cleanup.policy</code> supports empty values, which means infinite retention. |
There was a problem hiding this comment.
We could remind users that this use case is equivalent to setting retention.ms=-1 and retention.bytes=-1
There was a problem hiding this comment.
Could we move this paragraph to above line 139?
Note that cleanup.policy supports empty values => cleanup.policy now supports empty values
| leaderLogIfLocal match { | ||
| case Some(leaderLog) => | ||
| if (!leaderLog.config.delete) | ||
| if (!leaderLog.config.delete && leaderLog.config.compact) |
There was a problem hiding this comment.
@junrao WDYT? We have not discussed the support of DeleteRecordsRequest in the case where cleanup.policy is empty.
There was a problem hiding this comment.
Good catch. This change seems reasonable to me.
There was a problem hiding this comment.
@m1a2st please update KIP and upgrade.html to match this change.
There was a problem hiding this comment.
I have updated the upgrade.html and the KIP-1161, PTAL. Thanks
| leaderLogIfLocal match { | ||
| case Some(leaderLog) => | ||
| if (!leaderLog.config.delete) | ||
| if (!leaderLog.config.delete && leaderLog.config.compact) |
There was a problem hiding this comment.
Good catch. This change seems reasonable to me.
docs/upgrade.html
Outdated
| local log segments will be cleaned based on the values of <code>log.local.retention.bytes</code> and | ||
| <code>log.local.retention.ms</code>. | ||
| <br> | ||
| Note that <code>cleanup.policy</code> supports empty values, which means infinite retention. |
There was a problem hiding this comment.
Could we move this paragraph to above line 139?
Note that cleanup.policy supports empty values => cleanup.policy now supports empty values
Some sections are not very clear, and we need to update the
documentation.