MINOR: Move topic creation before consumer creation in testListGroups integration test

[lucliu1108]

This PR moves the topic creation before consumer creations in
PlaintextAdminIntegrationTest.testListGroups, to avoid potential
errors if consumer creates topic due to metadata update.

See discussion
#20244 (comment)

Reviewers: @chia7712, [email protected]

[chia7712]

Gradle Test Run :core:test > Gradle Test Executor 33 > PlaintextAdminIntegrationTest > testListGroups() FAILED
    org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
        at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
        at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
        at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
        at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
        at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
        at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
        at app//kafka.api.PlaintextAdminIntegrationTest.testListGroups(PlaintextAdminIntegrationTest.scala:2643)

The test is still flaky on my local machine. Perhaps it needs waitUntilTrue to ensure all groups are ready?

[lucliu1108]

Added a waitUtilTrue to wait until all groups are stable before validating the listGroup contents.

[apalan60]

@lucliu1108

Thanks for the fix. I looped this test 50 times locally and didn’t see any failures.
Also left a small suggestion.

[apalan60]

filteredClassicGroups.forall(_.groupState().orElse(null) == GroupState.STABLE) &&

It looks like this line is duplicated.

[bbejeck]

LGTM

[bbejeck]

Merged #20496 into trunk

[chia7712]

@bbejeck Could you please use committer-tools/reviewers.py to format the reviewers before merging the PR?

[chia7712]

Should we also add the check for simple group?