KAFKA-19809 CheckStyle version upgrade: 10.20.2 -->> 12.0.1 #20726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
dejan2609
commented
Oct 19, 2025
| <module name="ClassDataAbstractionCoupling"> | ||
| <!-- default is 7 --> | ||
| <property name="max" value="25"/> | ||
| <property name="max" value="27"/> |
There was a problem hiding this comment.
Options:
- increase limit (like here)
- create a baseline (skip/suppress this check for existing cases/classes)
- change existing classes and keep the old property value max limit
dejan2609
commented
Oct 19, 2025
| <module name="ClassFanOutComplexity"> | ||
| <!-- default is 20 --> | ||
| <property name="max" value="52"/> | ||
| <property name="max" value="55"/> |
There was a problem hiding this comment.
In a similar case, we also have three options:
- increase limit (like here)
- create a baseline (skip/suppress this check for existing cases/classes)
- change existing classes and keep the old property value max limit
dejan2609
commented
Oct 19, 2025
| <suppress checks="ImportControl" files="(JaasTestUtils).java" /> | ||
|
|
||
| <suppress checks="FinalLocalVariable" files="."/> | ||
| <suppress checks="FinalParameters" files="."/> |
There was a problem hiding this comment.
From my POV both of these checks are overzealous and hence I turned them off, but I'm open to a discussion.
Related links:
- https://checkstyle.sourceforge.io/checks/misc/finalparameters.html
- https://checkstyle.sourceforge.io/checks/coding/finallocalvariable.html
- https://softwareengineering.stackexchange.com/questions/48413/in-java-should-i-use-final-for-parameters-and-locals-even-when-i-dont-have-t
- https://stackoverflow.com/questions/3635863/why-method-parameters-needs-to-be-set-as-final
- https://stackoverflow.com/questions/500508/why-should-i-use-the-keyword-final-on-a-method-parameter-in-java
- https://www.reddit.com/r/learnjava/comments/1ffoa9p/using_final_in_method_parameters_your_opinion
|
Can you please take a look @chia7712 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: KAFKA-19809
Related link: https://checkstyle.org/releasenotes.html#Release_12.0.1
Reviews are welcome!
Relates to: checkstyle/checkstyle#16003