MINOR: Improve some requests/responses toString method #20759
Merged
+171
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Oct 23, 2025
| // It is not safe to print all config values | ||
| @Override | ||
| public String toString() { | ||
| JsonNode json = AlterConfigsRequestDataJsonConverter.write(data, version()).deepCopy(); |
There was a problem hiding this comment.
I left a comment in the email discussion thread
|
@lianetm would you mind including this patch in the 4.1.1? |
showuon
force-pushed
the
alterConfigToString
branch
from
eacd2c8 to
26ffff4
Compare
2. also improve the builder.toString()
showuon
changed the title
showuon
changed the title
omkreddy
approved these changes
Oct 24, 2025
chia7712
approved these changes
Oct 24, 2025
chia7712
reviewed
Oct 24, 2025
| return new AlterConfigsRequest.Builder(configs, false).build(version); | ||
| AlterConfigsRequest alterConfigsRequest = new AlterConfigsRequest.Builder(configs, false).build(version); | ||
| assertEquals( | ||
| "AlterConfigsRequestData(resources=[" + |
There was a problem hiding this comment.
The failed test is related to this, as the order of elements is not deterministic due to the HashMap
There was a problem hiding this comment.
Thanks @chia7712 ! LGTM! Let's wait for the CI build result.
chia7712
pushed a commit
that referenced
this pull request
Oct 25, 2025
Improve some requests/responses toString method to log only the required info, including the request.Builder toString methods. 1. AlterConfigsRequest 2. AlterUserScramCredentialsRequest 3. ExpireDelegationTokenRequest 4. IncrementalAlterConfigsRequest 5. RenewDelegationTokenRequest 6. SaslAuthenticateRequest 7. createDelegationTokenResponse 8. describeDelegationTokenResponse 9. SaslAuthenticateResponse Reviewers: Chia-Ping Tsai <[email protected]>, Manikumar Reddy <[email protected]>
|
I have pushed this patch to trunk and 4.1, but conflicts occurred in 4.0 and 3.9. will file a separate patch for those branches |
|
I’ll help Chia-Ping resolve the conflicts 😃 |
brandboat
pushed a commit
to brandboat/kafka
that referenced
this pull request
Oct 25, 2025
Improve some requests/responses toString method to log only the required info, including the request.Builder toString methods. 1. AlterConfigsRequest 2. AlterUserScramCredentialsRequest 3. ExpireDelegationTokenRequest 4. IncrementalAlterConfigsRequest 5. RenewDelegationTokenRequest 6. SaslAuthenticateRequest 7. createDelegationTokenResponse 8. describeDelegationTokenResponse 9. SaslAuthenticateResponse Reviewers: Chia-Ping Tsai <[email protected]>, Manikumar Reddy <[email protected]>
brandboat
pushed a commit
to brandboat/kafka
that referenced
this pull request
Oct 25, 2025
Improve some requests/responses toString method to log only the required info, including the request.Builder toString methods. 1. AlterConfigsRequest 2. AlterUserScramCredentialsRequest 3. ExpireDelegationTokenRequest 4. IncrementalAlterConfigsRequest 5. RenewDelegationTokenRequest 6. SaslAuthenticateRequest 7. createDelegationTokenResponse 8. describeDelegationTokenResponse 9. SaslAuthenticateResponse Reviewers: Chia-Ping Tsai <[email protected]>, Manikumar Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve some requests/responses toString method to log only the
required
info, including the request.Builder toString methods.
Reviewers: Chia-Ping Tsai [email protected], Manikumar Reddy
[email protected]