-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scanners to main repository #78
Conversation
What do you think @Humbedooh @michalslowikowski00 @sharanf ? Other option is that we accept what we have and then we fix it + add tests. |
If we move the scanners to the main repo and we leave them broken -- what are the consequences? what is the impact on the user? |
The proper answer is: users will be surprised. But they will also be surprised now 😄 I think we don't have thousands of users currently and we can risk merging everything and then fixing. This has the advantage of doing more work in parallel (scanners fixes, configuration refactor, etc) |
I agree, I don't think we have a lot of users downloading and setting up Kibble. My thought is that the majority of users are coming from within Apache to check on their own project statistics which they can do easily with the demo. That doesn't mean that we won't have some users out there that will be surprised that things are changing! Ideally if people are really upset then we will find out here or on the mailing list, and then we can look at doing something to ease them through it. For the scanners we did have a couple of requests to add some new ones, Gitlab, Slack and bitbucket so will need to bring those across into our current issue list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore this, I am just testing a webhook - will delete again :)
@sharanf @Humbedooh @michalslowikowski00 if there's no strong objection I will merge this PR |
This PR moves Apache Kibble scanners from
https://github.com/apache/kibble-scanners to https://github.com/apache/kibble
as discussed here:
https://lists.apache.org/thread.html/r3f373be93397fc55ad6aff11030d2f3eb93f0f34782ff58fba9325b1%40%3Cdev.kibble.apache.org%3E
I reviewed all files and fixed licenses headers, removed unused imports and adjusted imports. It seems to look good:
However, doing this review I found few errors in implementation (undefined variables, missing imports etc) and I'm wondering, wouldn't it be better to add the scanners one by one to improve them in this process?
Probably we should do this once we have #77