Use KibbleConfigParser in setup script #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
commented
Oct 27, 2020
| try: | ||
| return bool(self.get(section, key)) | ||
| except Exception: | ||
| raise TypeError("Unable to convert value to bool") |
There was a problem hiding this comment.
@skekre98 unfortunately I had to remove those method as it seems that ConfigParser already implements getint and getboolean
There was a problem hiding this comment.
No problem, I'm sure they have a better implementation anyways 😄
There was a problem hiding this comment.
@skekre98 would you mind reviewing those changes? 😉
skekre98
approved these changes
Oct 27, 2020
Closed
kaxil
referenced
this pull request
in kaxil/kibble
Dec 12, 2020
Before this commit I got this error when running Kibble locally: ``` kibble_1 | [2020-12-12 19:42:01 +0000] [7] [ERROR] Exception in worker process kibble_1 | Traceback (most recent call last): kibble_1 | File "/usr/local/lib/python3.8/site-packages/gunicorn/arbiter.py", line 583, in spawn_worker kibble_1 | worker.init_process() kibble_1 | File "/usr/local/lib/python3.8/site-packages/gunicorn/workers/base.py", line 119, in init_process kibble_1 | self.load_wsgi() kibble_1 | File "/usr/local/lib/python3.8/site-packages/gunicorn/workers/base.py", line 144, in load_wsgi kibble_1 | self.wsgi = self.app.wsgi() kibble_1 | File "/usr/local/lib/python3.8/site-packages/gunicorn/app/base.py", line 67, in wsgi kibble_1 | self.callable = self.load() kibble_1 | File "/usr/local/lib/python3.8/site-packages/gunicorn/app/wsgiapp.py", line 49, in load kibble_1 | return self.load_wsgiapp() kibble_1 | File "/usr/local/lib/python3.8/site-packages/gunicorn/app/wsgiapp.py", line 39, in load_wsgiapp kibble_1 | return util.import_app(self.app_uri) kibble_1 | File "/usr/local/lib/python3.8/site-packages/gunicorn/util.py", line 358, in import_app kibble_1 | mod = importlib.import_module(module) kibble_1 | File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module kibble_1 | return _bootstrap._gcd_import(name[level:], package, level) kibble_1 | File "<frozen importlib._bootstrap>", line 1014, in _gcd_import kibble_1 | File "<frozen importlib._bootstrap>", line 991, in _find_and_load kibble_1 | File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked kibble_1 | File "<frozen importlib._bootstrap>", line 671, in _load_unlocked kibble_1 | File "<frozen importlib._bootstrap_external>", line 783, in exec_module kibble_1 | File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed kibble_1 | File "/kibble/kibble/api/handler.py", line 49, in <module> kibble_1 | with open(KIBBLE_YAML, "r") as f: kibble_1 | FileNotFoundError: [Errno 2] No such file or directory: '/kibble/kibble/api/yaml/kibble.yaml' kibble_1 | [2020-12-12 19:42:01 +0000] [7] [INFO] Worker exiting (pid: 7) ``` This was because https://github.com/apache/kibble/pull/83 replaced kibble.yaml with kibble.ini This PR reads the config from `kibble.ini`. This also adds a network to docker-compose file without which I was getting host not found error.
Merged
turbaszek
referenced
this pull request
Dec 12, 2020
Before this commit I got this error when running Kibble locally: This was because https://github.com/apache/kibble/pull/83 replaced kibble.yaml with kibble.ini This PR reads the config from `kibble.ini`. This also adds a network to docker-compose file without which I was getting host not found error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up after #74
We still need to remove the using of
kibble.yamlin few places but I wanted to limit a scope of this changes (for example it would be good to refactor connecting to es database - currently we implement same class two times #84 ).