Use the NPM dependencies from the gha/v0 branch - #504
Merged
Merged
Conversation
The staging and production website builds now download `package.json` and `package-lock.json` from the `gha/v0` branch of `logging-parent`, so all Apache Logging websites share the same Antora dependency tree. Dependabot keeps those dependencies up to date there, which makes the local npm entry and the committed lock file redundant. Release website staging still uses the committed `package.json`, which now only points at the shared dependency set. Assisted-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion of apache/logging-parent#506 and apache/logging-parent#507, which centralize the NPM dependencies of all Apache Logging websites on the
gha/v0branch oflogging-parent.npm-dependencies-ref: gha/v0todeploy-site-reusable, so they build with the exact dependency tree from that branch. Release website staging keeps using the committedpackage.json.package.jsonshrinks to a single Git dependency ongha/v0;package-lock.jsonis no longer committed.gha/v0.Note
Ignoring the regenerated
package-lock.jsonis part of the companion PR that aligns.gitignorewith the other Logging repositories.🤖 Generated with Claude Code