Skip to content

Conversation

@garydgregory
Copy link
Member

@garydgregory garydgregory commented Oct 25, 2025

Fix spelling.

Important

Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise.

Checklist

Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.

✅ Required checks

  • License: I confirm that my changes are submitted under the Apache License, Version 2.0.

  • Commit signatures: All commits are signed and verifiable. (See GitHub Docs on Commit Signature Verification).

  • Code formatting: The code is formatted according to the project’s style guide.

    How to check and fix formatting
    • To check formatting: ./mvnw spotless:check
    • To fix formatting: ./mvnw spotless:apply

    See the build instructions for details.

  • Build & Test: I verified that the project builds and all unit tests pass.

    How to build the project

    Run: ./mvnw verify

    See the build instructions for details.

🧪 Tests (select one)

  • I have added or updated tests to cover my changes.
  • No additional tests are needed for this change.

📝 Changelog (select one)

  • I added a changelog entry in src/changelog/.2.x.x. (See Changelog Entry File Guide).
  • This is a trivial change and does not require a changelog entry.

I did run mvn clean verify -DskipTests.

@github-actions
Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@vy
Copy link
Member

vy commented Oct 26, 2025

@garydgregory, would you mind signing your commits, please? Otherwise, your PR cannot be merged. If you need guidance for that, ChatGPT responds well to the following prompt:

In a GitHub PR, how can I sign (not sign-off!) existing commits?

Note that you will need to push-force at the end.

@garydgregory
Copy link
Member Author

garydgregory commented Oct 27, 2025

@vy

git rebase -i --exec 'git commit --amend --no-edit -n -S' 2.x
Executing: git commit --amend --no-edit -n -S
error: gpg failed to sign the data:
[GNUPG:] KEY_CONSIDERED xxxxxxx
[GNUPG:] BEGIN_SIGNING H10
[GNUPG:] PINENTRY_LAUNCHED 82362 curses 1.3.2 - xterm-256color - - 501/20 0
gpg: signing failed: Inappropriate ioctl for device
[GNUPG:] FAILURE sign 83918950
gpg: signing failed: Inappropriate ioctl for device

fatal: failed to write commit object
warning: execution failed: git commit --amend --no-edit -n -S
You can fix the problem, and then run

  git rebase --continue

Always with the Byzantine bureaucracy...

Using "You can also merge this with the command line." doesn't work either (protected branch hook declined). Phew, I guess you're the gatekeeper now.

@ppkarwasz
Copy link
Contributor

Hi @garydgregory,

Always with the Byzantine bureaucracy...

It's rather some technical detail. Commits to 2.x and main require signatures since b1db50b (2024-04-22). Since then you have successfully merged PRs with unsigned commits.

For example e6392aa is unsigned, but GitHub signed it, when you merged the PR: 43a0e29. If setting up signing is a problem, we can discuss it on dev@logging.

Having only signed commits on 2.x and main provides a nice audit log, but maybe now GitHub is refusing to sign PRs, unless all the commits in the PR are signed.

@vy vy added the waiting-for-user More information is needed from the user label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-user More information is needed from the user

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

3 participants