Remove scoreAll() optimization from DefaultBulkScorer.

[jpountz]

I cannot see benefits from this optimization anymore when running luceneutil. However, I do see some benefits from specializing cases when the collector produces a competitive iterator or when the scorer produces a two-phase iterator.

[jpountz]

                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                    AndStopWords       32.62      (2.4%)       31.88      (5.8%)   -2.3% ( -10% -    6%) 0.162
                       CountTerm     8998.10      (3.2%)     8847.41      (4.5%)   -1.7% (  -9% -    6%) 0.242
                     OrStopWords       34.24      (4.9%)       33.72      (6.8%)   -1.5% ( -12% -   10%) 0.486
                       And3Terms      182.04      (1.5%)      179.43      (4.0%)   -1.4% (  -6% -    4%) 0.194
                          OrMany       20.04      (2.5%)       19.80      (4.3%)   -1.2% (  -7% -    5%) 0.353
             And2Terms2StopWords      167.96      (1.1%)      165.96      (3.9%)   -1.2% (  -6% -    3%) 0.260
              Or2Terms2StopWords      164.66      (2.5%)      163.24      (4.2%)   -0.9% (  -7% -    5%) 0.494
                        Or3Terms      173.70      (2.7%)      172.22      (4.3%)   -0.9% (  -7% -    6%) 0.515
              FilteredAndHighMed      132.06      (1.1%)      131.03      (3.0%)   -0.8% (  -4% -    3%) 0.350
                        PKLookup      286.74      (2.4%)      284.54      (2.9%)   -0.8% (  -5% -    4%) 0.433
                          Phrase       15.10      (3.6%)       15.00      (3.3%)   -0.7% (  -7% -    6%) 0.568
                     CountPhrase        4.39      (1.9%)        4.36      (2.0%)   -0.6% (  -4% -    3%) 0.378
                  FilteredOrMany       17.09      (1.9%)       16.99      (2.5%)   -0.6% (  -4% -    3%) 0.456
                        SpanNear        2.36      (0.7%)        2.35      (1.1%)   -0.3% (  -2% -    1%) 0.298
     FilteredAnd2Terms2StopWords      199.37      (0.9%)      198.77      (1.5%)   -0.3% (  -2% -    2%) 0.495
             FilteredAndHighHigh       63.03      (1.6%)       62.89      (1.8%)   -0.2% (  -3% -    3%) 0.724
               FilteredAnd3Terms      197.03      (1.6%)      196.61      (2.2%)   -0.2% (  -3% -    3%) 0.755
                          Fuzzy1       81.35      (1.7%)       81.20      (2.2%)   -0.2% (  -4% -    3%) 0.801
               CombinedOrHighMed       70.92      (4.1%)       70.80      (2.8%)   -0.2% (  -6% -    7%) 0.897
              CombinedAndHighMed       55.09      (3.6%)       55.01      (2.4%)   -0.1% (  -5% -    6%) 0.898
                   TermMonthSort     3437.51      (1.8%)     3433.52      (2.8%)   -0.1% (  -4% -    4%) 0.892
             CombinedAndHighHigh       15.15      (3.8%)       15.14      (2.7%)   -0.1% (  -6% -    6%) 0.935
            FilteredAndStopWords       48.36      (1.4%)       48.31      (1.8%)   -0.1% (  -3% -    3%) 0.877
              CombinedOrHighHigh       18.66      (4.3%)       18.64      (2.9%)   -0.1% (  -6% -    7%) 0.951
                     AndHighHigh       45.46      (2.0%)       45.43      (2.0%)   -0.1% (  -3% -    4%) 0.932
      FilteredOr2Terms2StopWords      148.72      (1.2%)      148.68      (1.0%)   -0.0% (  -2% -    2%) 0.958
                AndMedOrHighHigh       59.69      (1.5%)       59.70      (1.7%)    0.0% (  -3% -    3%) 0.977
             FilteredOrStopWords       43.75      (2.6%)       43.78      (2.1%)    0.1% (  -4% -    4%) 0.937
                FilteredOr3Terms      167.17      (1.3%)      167.32      (1.0%)    0.1% (  -2% -    2%) 0.832
                          Fuzzy2       76.68      (1.5%)       76.76      (1.8%)    0.1% (  -3% -    3%) 0.865
                 AndHighOrMedMed       44.75      (3.5%)       44.80      (2.3%)    0.1% (  -5% -    6%) 0.918
                        Wildcard       75.51      (2.2%)       75.66      (2.7%)    0.2% (  -4% -    5%) 0.826
                      AndHighMed      132.46      (1.9%)      132.82      (1.7%)    0.3% (  -3% -    3%) 0.684
                    FilteredTerm      154.62      (3.0%)      155.05      (3.4%)    0.3% (  -5% -    6%) 0.814
               FilteredOrHighMed      154.57      (1.4%)      155.01      (1.0%)    0.3% (  -2% -    2%) 0.536
                  FilteredPhrase       30.66      (1.1%)       30.76      (1.0%)    0.3% (  -1% -    2%) 0.412
                IntervalsOrdered        2.39      (3.7%)        2.40      (3.1%)    0.4% (  -6% -    7%) 0.756
                            Term      463.91      (4.5%)      465.86      (5.9%)    0.4% (  -9% -   11%) 0.826
                    SloppyPhrase        1.68      (7.7%)        1.69      (8.1%)    0.5% ( -14% -   17%) 0.868
                  CountOrHighMed      139.57      (1.8%)      140.26      (2.3%)    0.5% (  -3% -    4%) 0.520
                      DismaxTerm      597.19      (2.6%)      600.18      (4.0%)    0.5% (  -5% -    7%) 0.683
                 CountOrHighHigh       75.20      (2.4%)       75.58      (2.4%)    0.5% (  -4% -    5%) 0.560
                CountAndHighHigh       56.19      (1.4%)       56.50      (1.1%)    0.6% (  -1% -    3%) 0.238
              FilteredOrHighHigh       64.73      (2.6%)       65.10      (1.8%)    0.6% (  -3% -    5%) 0.481
                 CountAndHighMed      163.51      (2.2%)      164.55      (1.4%)    0.6% (  -2% -    4%) 0.345
                         Respell       54.69      (2.4%)       55.10      (1.6%)    0.7% (  -3% -    4%) 0.309
                         Prefix3      126.36      (5.5%)      127.39      (6.1%)    0.8% ( -10% -   13%) 0.700
                  TermBGroup1M1P       37.86      (3.6%)       38.31      (3.1%)    1.2% (  -5% -    8%) 0.335
                    CombinedTerm       29.55      (2.9%)       29.90      (2.5%)    1.2% (  -4% -    6%) 0.225
                 DismaxOrHighMed       83.66      (3.7%)       84.68      (3.8%)    1.2% (  -6% -    9%) 0.377
                DismaxOrHighHigh       67.43      (4.0%)       68.38      (4.3%)    1.4% (  -6% -   10%) 0.356
                       OrHighMed      193.39      (4.1%)      196.19      (4.3%)    1.4% (  -6% -   10%) 0.341
                    TermBGroup1M       24.66      (4.1%)       25.02      (4.3%)    1.5% (  -6% -   10%) 0.330
                     TermGroup1M       19.58      (3.8%)       19.90      (3.9%)    1.6% (  -5% -    9%) 0.245
                      OrHighHigh       52.75      (5.2%)       53.63      (5.5%)    1.7% (  -8% -   13%) 0.392
                    TermGroup10K       19.92      (3.8%)       20.28      (4.1%)    1.8% (  -5% -   10%) 0.216
                   TermTitleSort      154.69      (2.2%)      157.77      (2.7%)    2.0% (  -2% -    7%) 0.026
                    TermGroup100       24.13      (4.8%)       24.61      (4.4%)    2.0% (  -6% -   11%) 0.231
               TermDayOfYearSort      627.76      (2.3%)      643.84      (2.6%)    2.6% (  -2% -    7%) 0.004
                      OrHighRare      266.96     (10.5%)      274.43      (6.7%)    2.8% ( -13% -   22%) 0.385
                          IntNRQ      109.60     (10.7%)      117.69     (17.8%)    7.4% ( -19% -   40%) 0.169
                      TermDTSort      275.82     (14.7%)      302.20      (6.4%)    9.6% ( -10% -   36%) 0.021

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

[gsmiller]

Looks good. Left one very minor question/comment.

[gsmiller]

nit: Any reason to not put this in the for-loop control statement itself? Seems slightly more idiomatic?

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!