-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent KNN query results with multiple leafs #14191
base: main
Are you sure you want to change the base?
Conversation
preliminary tests with luceneutil on Cohere-768. with force-merge=true
candidate
without force-merge
candidate
these are meant to check that the latency doesn't change (increase) with these changes. |
lucene/core/src/java/org/apache/lucene/search/knn/MultiLeafKnnCollector.java
Show resolved
Hide resolved
I've adjusted |
my previous luceneutil runs were useless, now with changes in luceneutil ( baseline
candidate (use first segment)
candidate (use largest segment)
|
I'm going to try a more promising way of slicing segments to threads |
This is a first attempt at fixing #14180.
It's based on @jpountz idea mentioned here.