Automatically remove dead states from concatenated automata. #14205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concatenating automata frequently creates dead states. This PR suggests that `Operations#concatenate` automatically removes these dead states. This is not unseen: `Operations#repeat`, `Operations#union` and other automaton manipulation utilities also automatically remove dead states.
|
It's in my PR over there too. I think we should avoid addEpsilon in the test. We don't even need any transitions. |
|
Superseded by #14193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concatenating automata frequently creates dead states. This PR suggests that
Operations#concatenateautomatically removes these dead states. This is not unseen:Operations#repeat,Operations#unionand other automaton manipulation utilities also automatically remove dead states.Here is an example of what concatenating automata that accept "f" and "g" returns, without this patch:
With this patch, state 3 gets removed.
Relates #14193.