Make Operations#union merge accept states that have no outgoing transition. #14207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition. This helps generate simpler automata, especially when these automata are later combined through other operations such as `Operations#concat`.
rmuir
reviewed
Feb 7, 2025
| @@ -1052,6 +1052,77 @@ public static Automaton removeDeadStates(Automaton a) { | |||
| return result; | |||
| } | |||
|
|
|||
| /** Merge all accept states that don't have outgoing transitions to a single shared state. */ | |||
There was a problem hiding this comment.
I like the idea, couldn't we potentially use this for other operations such as reverse() which might cause the same inefficiency as union() today?
Can we hit it with a simple random test for good feelings about it?
for (int i = 0; i < N; i++) {
Automaton expected = AutomatonTestUtil.randomAutomata(random);
Automaton actual = mergeAcceptStates(expected);
assertSameLanguage(expected, actual);
}
jpountz
added a commit
that referenced
this pull request
Feb 10, 2025
…ition. (#14207) This helps generate simpler automata, especially when these automata are later combined through other operations such as `Operations#concat`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps generate simpler automata, especially when these automata are later combined through other operations such as
Operations#concat.