Deprecate Operations.concat(a1, a2) and Operations.union(a1, a2) #14209
Conversation
These algorithms run in linear time: it is trappy to offer two-arg options: they encourage users to use them in a loop and create quadratic time. Send a strong signal to the user's editor/IDE to avoid trouble in the first place: * Deprecate two-arg methods in favor of the List-based versions * Rename parameter 'l' to 'list' * Add javadoc @param to parameter 'list'
|
I will look into the test fail, I did run them many times, but I was also pretty aggressive about trying to cleanup tests, so that we can just remove the deprecations in a followup commit, and improve efficiency in some places too. Code in the tests and suggester were impacted in this way. |
|
The problem is not related to this PR from what I can tell, the issue is that I can reproduce it in main: I will deal with it separately. |
|
To me the deprecation is easy enough, developer is usually responsive to such things. It comes across different than just a hard break in a few ways, usually you question why the previous thing was deprecated and it causes you to take a second look. Versus just trying to make the code compile again. I'd rather us give the helpful nudge to make the code more efficient? |
These algorithms run in linear time: it is trappy to offer two-arg options: they encourage users to use them in a loop and create quadratic time.
Send a strong signal to the user's editor/IDE to avoid trouble in the first place:
@paramto parameter 'list'Closes #14202