Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CombinedFieldQuery to the core module. #14236

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Feb 13, 2025

CombinedFieldQuery is Lucene's most robust way of scoring across multiple fields, let's move it to core and recommend using it to query multiple fields.

While moving the class, I modified the API so that it supports configuring a single term.

`CombinedFieldQuery` is Lucene's most robust way of scoring across
multiple fields, let's move it to core and recommend using it to query
multiple fields.
@jpountz jpountz added this to the 10.2.0 milestone Feb 13, 2025
@gsmiller gsmiller changed the title Move CombinedFieldQuery to the code module. Move CombinedFieldQuery to the core module. Feb 14, 2025
@jpountz
Copy link
Contributor Author

jpountz commented Feb 19, 2025

Thanks for correcting the title @gsmiller.

This doesn't look controversial to me and there haven't been objections, so I'm feeling free to merge.

@jpountz jpountz merged commit 239059e into apache:main Feb 19, 2025
6 checks passed
@jpountz jpountz deleted the move_combined_field_query_core branch February 19, 2025 12:32
jpountz added a commit that referenced this pull request Feb 19, 2025
`CombinedFieldQuery` is Lucene's most robust way of scoring across
multiple fields, let's move it to core and recommend using it to query
multiple fields.
@gsmiller
Copy link
Contributor

Thanks for correcting the title @gsmiller.

Ha, sorry couldn't help fixing the typo. I had this open to have a look then got busy with other stuff and never came back to it (wanted to dig in a bit more on CombinedFieldQuery since I'm unfamiliar with it, but agreed that moving it out of sandbox doesn't appear to be a concern)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants