Repeatable hunspell tests #14246
Merged
Repeatable hunspell tests #14246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweiss
commented
Feb 16, 2025
Comment on lines
+29
to
+30
| -Ptests.hunspell.libreoffice.ref=master | ||
| -Ptests.hunspell.woorm.ref=main |
There was a problem hiding this comment.
Here we pick the 'latest' commit from both branches for the scheduled workflow.
Comment on lines
+42
to
+53
| def dictionaryProjects = [ | ||
| [ | ||
| "libreoffice": "https://github.com/LibreOffice/dictionaries", | ||
| "woorm": "https://github.com/wooorm/dictionaries" | ||
| ].each { name, repo -> | ||
| if (!file("${checkoutDir}/${name}").exists()) { | ||
| checkoutDir.mkdirs() | ||
| // This will work only if git is available, but I assume it is. | ||
| project.exec { | ||
| "name": "libreoffice", | ||
| "url": "https://github.com/LibreOffice/dictionaries", | ||
| "ref": "762abe74008b94b2ff06db6f4024b59a8254c467" // head: master | ||
| ], | ||
| [ | ||
| "name": "woorm", | ||
| "url": "https://github.com/wooorm/dictionaries", | ||
| "ref": "8cfea406b505e4d7df52d5a19bce525df98c54ab" // head: main | ||
| ] | ||
| ] |
There was a problem hiding this comment.
This will need to be updated by hand, occasionally. The frequency of changes in those repositories isn't that great so no problem there, I think?
There was a problem hiding this comment.
yes, honestly any revision will work for the intended purpose of preventing regressions. If we want to discover new and interesting ways that dictionaries can be malformed in the wild that we should try to detect, that is different :)
Comment on lines
+66
to
+73
| opens org.apache.lucene.util.fst to | ||
| org.apache.lucene.test_framework; | ||
| opens org.apache.lucene.store to | ||
| org.apache.lucene.test_framework; | ||
| opens org.apache.lucene.util.automaton to | ||
| org.apache.lucene.test_framework; | ||
| opens org.apache.lucene.util to | ||
| org.apache.lucene.test_framework; |
There was a problem hiding this comment.
Had to add these to make ram testing happy now that the tests run in module mode.
rmuir
approved these changes
Feb 16, 2025
|
Thanks. I'll backport to 10x as well. |
dweiss
added a commit
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14235
Sorry this took surprisingly long. I've tried to clean up a few things along the way:
-Ptests.hunspell.libreoffice.ref=masterwill test against the master branch (or any other sha provided there). For woorm, it's-Ptests.hunspell.woorm.ref=main.I also cleaned up gradle scripts a bit.
-Ptests.hunspell.regressions=true. The separate task wasn't configured properly (it wasn't running in module mode) and in general I think it's better to just keep the 'test' task for running tests.TestAllDictionariesclass, not everything.I also had to open up some core packages to the test framework - this is a side effect of TestAllDictionaries measuring memory of Dictionary objects it creates. I think it'd be nice to make Dictionary implement Accountable and remove opens statements but it's probably a follow up issue.