assertDocValuesEquals should support sparse sorted doc_values #14839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LuceneTestCase, assertDocValuesEquals compares the doc_values in two indices. For SortedSetDocValues, as well as other doc value types, it does not assume that every document has a value. But for SortedDocValues, it requires that every doc have a value. Remove this restriction.
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
parkertimmins
commented
Jun 25, 2025
| document.removeFields("sparseset"); | ||
| if (random.nextBoolean()) { | ||
| document.add(new SortedDocValuesField("sparseset", new BytesRef(title))); | ||
| } |
There was a problem hiding this comment.
This function is also used in TestDuelingCodecsAtNight. This comment:
jpountz
approved these changes
Jun 25, 2025
|
Can you add a CHANGES entry under 10.3 before I merge? |
|
@jpountz Whoops, I missed that it needed a change log entry. Thanks for the heads up. Add an entry to the 10.3 section. Thanks! |
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
benwtrent
pushed a commit
that referenced
this pull request
Jul 9, 2025
* assertDocValuesEquals should support sparse sorted doc_values In LuceneTestCase, assertDocValuesEquals compares the doc_values in two indices. For SortedSetDocValues, as well as other doc value types, it does not assume that every document has a value. But for SortedDocValues, it requires that every doc have a value. Remove this restriction. * add change to CHANGES.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LuceneTestCase, assertDocValuesEquals compares the doc_values in two indices. For SortedSetDocValues, as well as other doc value types, it does not assume that every document has a value. But for SortedDocValues, it requires that every doc have a value. This restricts what indices
assertDocValuesEqualscan be used to test. So this PR removes this restriction and does not assume that every doc has a value.