chore(java): fix typos #14859
chore(java): fix typos #14859
Conversation
Just one typo fixed in many places
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
|
Thank you! |
This reverts commit 4a34692.
|
I had to revert this, unfortunately - the builds started to go crazy after this change. Something depends on this spelling mistake. Here is an example: |
|
If you can look into this again and correct this behavior - please file another PR. Thank you and sorry! |
|
Did you figure out why this was not detected by the Github runners? Actually all Jenkins builds fail. I was thinking it is maybe the length of the text string which causes the highlighter to produce a different fragment. |
|
No, I'm on holidays and only occasionally checking email. It is surprising that it failed on jenkins but not on the CI - let me take a look. |
|
Something is definitely not right because that test... failed in the CI but the build passed. I'm looking at it. |
|
It's a build system regression that caused the CI to pass: #14944 |
|
I've reapplied this patch here: |
|
This is bewildering ... I guess there is some kind of megaflux capacitor quantum entanglement between this typo fix and the halt-on-failure fix? |
|
Good one. :) This patch showed a green CI status so I merged it in. But if you go and check the logs, it actually failed the test - This can also be the case with other PRs against main, sadly. I switched the default on one of the test-task control flags while rewriting the code. Errare humanum est. |
|
As for explaining why CI jobs on jenkins failed - this is due to the fact that Jenkins parses test output XMLs (I believe) and it detects test failures in addition to looking at the overall build status. |
|
It also does not use all of the system properties you changed, but passes cmd line option "--continue" to gorefully proceed with all tasks. /home/jenkins/workspace/Lucene-main-Linux/gradlew -Dtests.haltonfailure=false -Dtests.badapples=false --continue --stacktrace check And yes, at end it finds test XML files and reports failures. There's also a difference. If exit code is non success build gets marked as failed, otherwise it gets yellow and reports only test failures (see above). |
|
The latter is nice, because one can quickly see that compilation failed vs. only tests failed on the indicator. |
|
ah thanks for explaining; we were passing builds even though there were failing tests, so the highlighting test typo fix PR looked green and we merged it, phew |
Just one typo fixed in many places
Description