Utilize docIDRunEnd on ReqExclBulkScorer #14976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
dweiss
pushed a commit
that referenced
this pull request
Jul 22, 2025
|
Thank you. I've applied this to main and branch_10x. Please keep an eye on: Tests are randomized so sometimes what passes on github's PR workflows breaks the build in a different configuration (nothing wrong with that - it's how it's designed to work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #14806 is reverted because it causes some test broken (sorry about that). This PR tries to fix it and re-raise the same logic. This comment explains why it causes problem. I think this might be helpful when some must not clauses implements its own
docIDRunEnd, although currently there is no such task in luceneutil.I've test the specific failed test locally with command below: