Skip to content

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Oct 10, 2025

Description

@dweiss
Copy link
Contributor

dweiss commented Oct 10, 2025

I don't think we should add such trackers to javadoc. To the website - yes, but not to the javadoc. I don't think it'll be useful.

@rmuir
Copy link
Member

rmuir commented Oct 10, 2025

Maybe it could tell us something about the versions of the documentation being looked up

@dweiss
Copy link
Contributor

dweiss commented Oct 10, 2025

I'm reluctant about this. It gets added to all javadocs everywhere - even if you generate them locally. I'm not so fond of those trackers, maybe that's why I feel uneasy about adding them here.

@rmuir
Copy link
Member

rmuir commented Oct 10, 2025

If you install ublock origin lite, the network request will never even happen.

@dweiss
Copy link
Contributor

dweiss commented Oct 10, 2025

I do have it. It's in my head though (the tracker).

@pabloem
Copy link
Member Author

pabloem commented Oct 10, 2025 via email

@dweiss
Copy link
Contributor

dweiss commented Oct 11, 2025

Would it be ok to add it optionally? So, for example, we can add it only to releases?

@pabloem
Copy link
Member Author

pabloem commented Oct 11, 2025

I moved the tracker to be added when building release javadoc! (depending on lucenedocurl, which is only defined on releases). LMK what y'all think @dweiss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants