Skip to content

test(windows): run managed workspace crash gates #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackwener merged 1 commit into from
Aug 8, 2026
Merged

test(windows): run managed workspace crash gates #2509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/windows-baseline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,18 @@ jobs:
Get-Content "$env:WINDOWS_BASELINE_LOG_DIR/storage.log"
exit $exitCode

- id: managed_workspace_crash
name: Run managed workspace crash recovery gates
if: always() && steps.build.outcome == 'success'
continue-on-error: true
shell: pwsh
run: |
$env:MAKA_STORAGE_STRESS = '1'
node.exe --test --test-concurrency=1 --test-name-pattern="real process crash|real crash|real-process crash|crash after baseline ref publication" packages/storage/dist/__tests__/managed-workspace-baseline.test.js packages/storage/dist/__tests__/git-workspace-service.test.js *> "$env:WINDOWS_BASELINE_LOG_DIR/managed-workspace-crash.log"
$exitCode = $LASTEXITCODE
Get-Content "$env:WINDOWS_BASELINE_LOG_DIR/managed-workspace-crash.log"
exit $exitCode

- id: processes
name: Audit residual job processes
if: always()
Expand Down Expand Up @@ -223,6 +235,7 @@ jobs:
| Script tests | ${{ steps.scripts.outcome }} |
| CLI / Electron smoke | ${{ steps.smoke.outcome }} |
| Storage suite | ${{ steps.storage.outcome }} |
| Managed workspace crash recovery | ${{ steps.managed_workspace_crash.outcome }} |
| Residual processes | ${{ steps.processes.outcome }} |

Download the `windows-baseline` artifact for complete logs.
Expand Down
6 changes: 5 additions & 1 deletion scripts/windows-baseline-workflow.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,15 @@ test('Windows baseline workflow keeps its non-blocking evidence contract', async
assert.match(workflow, /^\s+continue-on-error: true$/mu);
assert.match(workflow, /^\s+timeout-minutes: 45$/mu);

const stepIds = [...workflow.matchAll(/^\s+- id: ([a-z]+)$/gmu)].map((match) => match[1]);
const stepIds = [...workflow.matchAll(/^\s+- id: ([a-z_]+)$/gmu)].map((match) => match[1]);
assert.deepEqual(stepIds, [
'install',
'build',
'inventory',
'scripts',
'smoke',
'storage',
'managed_workspace_crash',
'processes',
]);
for (const stepId of stepIds) {
Expand All @@ -79,6 +80,7 @@ test('Windows baseline workflow keeps its non-blocking evidence contract', async
'npm.cmd run test:scripts',
'npm.cmd run smoke:windows',
'node.exe scripts/run-workspace-tests-parallel.mjs --concurrency=1 --workspaces=packages/storage',
'node.exe --test --test-concurrency=1 --test-name-pattern="real process crash|real crash|real-process crash|crash after baseline ref publication" packages/storage/dist/__tests__/managed-workspace-baseline.test.js packages/storage/dist/__tests__/git-workspace-service.test.js',
]) {
assert.ok(workflow.includes(command), command);
}
Expand All @@ -103,6 +105,8 @@ test('Windows baseline workflow keeps its non-blocking evidence contract', async
/--workspaces=packages\/storage \*> "\$env:WINDOWS_BASELINE_LOG_DIR\/storage\.log"/u,
);
assert.match(workflow, /Get-Content "\$env:WINDOWS_BASELINE_LOG_DIR\/storage\.log"/u);
assert.match(workflow, /\$env:MAKA_STORAGE_STRESS = '1'/u);
assert.match(workflow, /managed-workspace-crash\.log/u);
// Pin-short-comment contract: the workflow must pin upload-artifact to a
// full SHA and annotate it with the exact version it resolves to. The major
// is intentionally not asserted — dependabot may bump it — but the
Expand Down
Loading