Warn when aggregate runs on non-POM packaging

[kratos0718]

Fixes #306

Problem

AggregatorSourceJarMojo.doExecute() packages sources only for pom packaging:

protected void doExecute() throws MojoException {
    if (Type.POM.equals(getProject().getPackaging().type().id())) {
        packageSources(reactorProjects);
    }
}

Any other packaging falls off the end of the method. No archive is produced and nothing is logged, so there is no way to tell the skip apart from a build that simply did not reach the goal.

Fix

Add the else branch and warn, naming the project and its actual packaging so the message says what to change. The wording follows the classifier warning packageSources already emits.

Testing

AggregatorSourceJarMojoTest covers both branches, overriding packageSources to record the projects it receives rather than building an archive:

• pom packaging still packages the reactor projects, and logs nothing
• non-POM packaging packages nothing and warns, with the message naming the packaging and the project

The second fails against the silent version with Wanted but not invoked; the first passes either way, since that branch is unchanged. mvn verify -DskipITs: 12 tests, all passing.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[elharo]

I'm unsure about this. Maybe debug level? I don't know.

[kratos0718]

Debug would leave it effectively silent, which is the thing #306 is about — nobody runs with -X unless they already suspect something is wrong, and the whole failure mode here is that you have no reason to suspect anything. The build succeeds and no source jar appears.

Warn felt right because it only fires when the goal was asked to do something it cannot do, so it isn't noise on a normal build. Your issue also suggested "a warning or info message", which is where I took it from.

That said, info is a reasonable middle if warn feels too loud — it still shows on a default run. Say the word and I'll switch it.

[kratos0718]

@elharo just following up, did you have a preference between warn and info for this, or is warn fine as is? Happy to switch it either way, just want to close this out.