Skip to content

Implement fail-fast behavior for JUnit Platform provider #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2025
Merged

Implement fail-fast behavior for JUnit Platform provider #3155

merged 2 commits into from
Aug 12, 2025

Conversation

marcphilipp
Copy link
Contributor

@marcphilipp marcphilipp commented Jul 9, 2025 •
edited
Loading

Resolves #2038.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This was referenced Jul 9, 2025
Closed
Open
Closed
@cstamas
Copy link
Member

cstamas commented Jul 9, 2025

Wow, cool! Thanks

marcphilipp
marcphilipp commented Jul 9, 2025
View reviewed changes
@marcphilipp marcphilipp marked this pull request as draft July 9, 2025 08:47
@marcphilipp
Copy link
Contributor Author

I've changed this PR to "draft" because it requires at least a milestone release of JUnit 6.0.0 to be merged. I've opened it early so I can address any feedback you might have.

@marcphilipp
Copy link
Contributor Author

Moreover, this PR supersedes #503

marcphilipp
marcphilipp commented Jul 9, 2025
View reviewed changes
...re-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/LauncherAdapter.java Outdated
Comment on lines 35 to 36
static final Class<?> LAUNCHER_EXECUTION_REQUEST_CLASS = loadLauncherExecutionRequestClass();
static final Class<?> CANCELLATION_TOKEN_CLASS = loadCancellationTokenClass();
static final Supplier<CancellationTokenAdapter> CANCELLATION_TOKEN_FACTORY = createCancellationTokenFactory();
static final Method EXECUTE_METHOD_WITH_LAUNCHER_EXECUTION_REQUEST_PARAMETER =
findExecuteMethodWithLauncherExecutionRequestParameter();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class heavily relies on reflection to keep compatible with pre-6.x versions of JUnit

@sormuras
Copy link
Contributor

With JUnit 6 in play, testing with JDK 8 and 11 are out - as JDK 17 is the new minimum.

@marcphilipp
Copy link
Contributor Author

With JUnit 6 in play, testing with JDK 8 and 11 are out - as JDK 17 is the new minimum.

Done in 4221aca

@marcphilipp
Copy link
Contributor Author

@cstamas Could you please approve workflow execution? I think all tests should be green now. 🤞

@marcphilipp marcphilipp moved this from Todo to In Review in Sovereign Tech Fund Jul 18, 2025
@marcphilipp
Copy link
Contributor Author

One more time, please! 😬

@marcphilipp
Copy link
Contributor Author

The one remaining failure looks unrelated. Is that test known to be flaky? 🤔

@olamy
Copy link
Member

olamy commented Jul 19, 2025

Great! Thanks for this.

@marcphilipp
Copy link
Contributor Author

I'll update this PR early next week after which it should be ready to be merged.

@marcphilipp marcphilipp force-pushed the marc/junit-platform-fail-fast branch 5 times, most recently from 5cb20ea to dd77018 Compare July 22, 2025 09:53
@marcphilipp marcphilipp force-pushed the marc/junit-platform-fail-fast branch from dd77018 to d834468 Compare July 22, 2025 09:56
@marcphilipp marcphilipp marked this pull request as ready for review July 22, 2025 09:57
@marcphilipp
Copy link
Contributor Author

I've rebased this PR to include the latest changes from the default branch and updated the integration test to use JUnit 6.0.0-M2. From my perspective, it's ready to be reviewed and then merged now.

@Bukama Bukama requested review from slawekjaranowski and olamy July 22, 2025 10:02
@Bukama Bukama added the enhancement New feature or request label Jul 22, 2025
@marcphilipp marcphilipp mentioned this pull request Jul 22, 2025
Open
8 tasks
@marcphilipp
Copy link
Contributor Author

I pushed another commit that should fix the problem on JDK 17 and later

olamy
olamy approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@marcphilipp
Copy link
Contributor Author

@olamy Can this PR be merged?

@olamy olamy merged commit 0fbfb27 into apache:master Aug 12, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Sovereign Tech Fund Aug 12, 2025
@github-actions github-actions bot added this to the 3.5.4 milestone Aug 12, 2025
@olamy
Copy link
Member

olamy commented Aug 12, 2025

@olamy Can this PR be merged?

Sorry for delay and thanks a lot for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

Assignees

@marcphilipp marcphilipp

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.5.4
Development

Successfully merging this pull request may close these issues.

[SUREFIRE-1710] skipAfterFailureCount in JUnit5 provider
5 participants
@marcphilipp @cstamas @sormuras @olamy @Bukama