[maven-4.0.x] Fix StackOverflowError in parent POM resolution (backport #11106) #11234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit backports the fix from PR apache#11106 to the maven-4.0.x branch. The fix addresses issue apache#11009 where Maven would encounter a StackOverflowError when resolving parent POMs that form a cycle. ## Problem When Maven encounters a cyclic dependency in parent POM resolution (e.g., A -> B -> A), it would enter an infinite recursion loop, eventually causing a StackOverflowError. This made Maven crash ungracefully without providing useful feedback to the user. ## Solution The fix implements cycle detection in the DefaultModelBuilder by: 1. **Tracking visited parents**: Maintains a set of visited parent coordinates during resolution 2. **Cycle detection**: When a parent that has already been visited is encountered again, it indicates a cycle 3. **Graceful error handling**: Throws a ModelBuildingException with a clear error message instead of crashing ## Changes Made - **Modified DefaultModelBuilder**: Added cycle detection logic in parent POM resolution methods - **Added integration test**: Comprehensive test case that verifies the fix works correctly - **Test resources**: Created test POMs with cyclic parent dependencies ## Testing The fix includes a comprehensive integration test (MavenITmng11009StackOverflowParentResolutionTest) that: - Creates a scenario with cyclic parent dependencies (A -> B -> A) - Verifies that StackOverflowError no longer occurs - Confirms that an appropriate cycle detection error is thrown - Ensures Maven fails gracefully with a meaningful error message ## Backward Compatibility This change is backward compatible as it only affects error handling for invalid POM structures. Valid POMs continue to work as before, while invalid cyclic structures now fail gracefully instead of crashing.
gnodet
changed the title
gnodet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the fix from #11106 to the maven-4.0.x branch.
Problem
When Maven encounters a cyclic dependency in parent POM resolution (e.g., A -> B -> A), it would enter an infinite recursion loop, eventually causing a StackOverflowError. This made Maven crash ungracefully without providing useful feedback to the user.
Solution
The fix implements cycle detection in the
DefaultModelBuilderby:ModelBuildingExceptionwith a clear error message instead of crashingChanges Made
DefaultModelBuilder: Added cycle detection logic in parent POM resolution methodsParentCycleDetectionTest) that verifies the fix works correctlyMavenITmng11009StackOverflowParentResolutionTest) with test resourcesTesting
The fix includes comprehensive tests that:
Backward Compatibility
This change is backward compatible as it only affects error handling for invalid POM structures. Valid POMs continue to work as before, while invalid cyclic structures now fail gracefully instead of crashing.
Related Issues
Pull Request opened by Augment Code with guidance from the PR author