Skip to content

nimble/ll: Add missing NULL pointer check #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkasenberg wants to merge 2 commits into from
Closed

nimble/ll: Add missing NULL pointer check #2038

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb23027
nimble/ll: Add missing NULL pointer check
mkasenberg May 20, 2025
9e2bf07
Merge branch 'apache:master' into fix-scan-cancel
mkasenberg Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nimble/controller/src/ble_ll_sched.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,6 +930,11 @@ ble_ll_sched_rmv_elem_type(uint8_t type, sched_remove_cb_func remove_cb)
OS_ENTER_CRITICAL(sr);

first = TAILQ_FIRST(&g_ble_ll_sched_q);
if (!first) {
OS_EXIT_CRITICAL(sr);
return;
Copy link
Contributor

@andrzej-kaczmarek andrzej-kaczmarek May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OS_EXIT_CRITICAL is missing here

}

if (first->sched_type == type) {
first_removed = 1;
}
Comment on lines 938 to 940
Copy link
Contributor

@MariuszSkamra MariuszSkamra Aug 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this needs to be fixed as well as first_removed can be left uninitialized.

Expand Down