Improve goto search windows #8896
Open
+499
−473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Editor
ci:dev-build
mbien
commented
Oct 9, 2025
|
|
||
| public boolean isSortingPreferOpenProjects() { | ||
| return getSortingNode().getBoolean(KEY_SORTING_PRJ, true); | ||
| return getSortingNode().getBoolean(KEY_SORTING_PRJ, false); |
There was a problem hiding this comment.
just a thought: we could also use this opportunity to fix the typo in the key, this would have the effect that the setting will be reset on NB upgrade. Which might be desirable too.
There was a problem hiding this comment.
done. Setting moved from global options to the search windows anyway.
- make exact search mode follow the case sensitivity settings - add missing exact search instructions to file search label (other windows had those) - file search: selection should stick to first item until user changes selection. Async search could otherwise insert better matches above the selected item - disable "prefer opened projects" by default - CI: enabled tests - other minor improvements the "prefer opened projects" setting can lead to confusing results when good matches are displayed far away from the first (worse) match, potentially outside of the visible viewport. The implementation itself works correctly but it might be better to change it into a filter instead of model comparator in future and consolidate the UI/settings of the 3 search dialogs.
- removed the setting from global options and moved it to the three search windows - generics and related language renovationss - file search: renamed "Search by Folder" to "Search by Path" - updated mnemonics
mbien
force-pushed
the
improve-goto-search
branch
from
4369b9e to
b6818ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first commit:
the "prefer opened projects" setting can lead to confusing results when good matches are displayed far away from the first (worse) match, potentially outside of the visible viewport. The implementation itself works correctly but it might be better as toggle in the search window settings instead of the more hidden global options.
second commit:
(other two windows look similar, but they may have less options)
fixes #4311
https://issues.apache.org/jira/browse/NETBEANS-3808
https://issues.apache.org/jira/browse/NETBEANS-3017