Skip to content

Add support for GlassFish 7.1.0, and GlassFish 8.0.0-M14 #9072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dmainardi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for GlassFish 7.1.0, and GlassFish 8.0.0-M14 #9072

dmainardi wants to merge 1 commit into from
+152 −28

Conversation

@dmainardi
Copy link

@dmainardi dmainardi commented Dec 8, 2025

Thanks @pepness

NetBeans GlassFish module notes:

Add support for GlassFish 7.1.0
Add support for GlassFish 8.0.0-M14

Release Notes for GlassFish 7
Release Notes for GlassFish 8

@dmainardi dmainardi marked this pull request as draft December 8, 2025 14:42
@dmainardi dmainardi marked this pull request as ready for review December 8, 2025 14:42
@dmainardi dmainardi marked this pull request as draft December 8, 2025 14:44
@dmainardi dmainardi marked this pull request as ready for review December 8, 2025 14:50
@mbien mbien added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Dec 8, 2025
@mbien mbien added this to the NB29 milestone Dec 8, 2025
@apache apache locked and limited conversation to collaborators Dec 8, 2025
@apache apache unlocked this conversation Dec 8, 2025
@mbien mbien requested a review from pepness December 8, 2025 15:46
@dmainardi
Copy link
Author

dmainardi commented Dec 8, 2025

Even if tests pass Netbeans is not able to start Glassfish 7.1.0. I think it is because of Glassfish's breaking changes made for this release, for example see eclipse-ee4j/glassfish#25553 or eclipse-ee4j/glassfish#25183
I tried to understand the code but I failed, it was the first time with Netbeans and Glassfish code.
I leave the error (and the fixing) to someone else ;-)
Thanks!

pepness
pepness requested changes Dec 8, 2025
View reviewed changes
Copy link
Member

@pepness pepness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new releases from GlassFish (8M14 / 7.1.0) had some breaking changes, when you register the server there is an error and when you try to start the server a different error appear.

Please compile this PR and test it locally to verify that it work on your machine and if it not work like in mine compare the errors.

enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java
GlassFishVersion.GF_8_0_0,
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip", // NOI18N
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip", // NOI18N
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M14.zip", // NOI18N
Copy link
Member

@pepness pepness Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing M12 to M14 change

enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip", // NOI18N
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip", // NOI18N
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M14.zip", // NOI18N
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M14.zip", // NOI18N
Copy link
Member

@pepness pepness Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing M12 to M14 change

...assfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/GlassFishV7_1_0.xml
</fileset>
</classpath>
<javadocs>
<link url="https://repo.maven.apache.org/maven2/org/glassfish/jersey/jersey-documentation/3.1.10/jersey-documentation-3.1.10-docbook.zip"/>
Copy link
Member

@pepness pepness Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be version 3.1.11

...ish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/admin/AdminFactoryTest.java

/**
* Test factory functionality for GlassFish v. 7.0.25
* Test factory functionality for GlassFish v. 7.1.0
Copy link
Member

@pepness pepness Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better reverse this to GlassFish version 7.0.25 and create a new test testGetInstanceforVersionGF71(), as this is a medium update going from 7.0.X to 7.Y.X.

@mbien mbien removed this from the NB29 milestone Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pepness pepness pepness requested changes

Assignees

No one assigned

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmainardi @pepness @mbien