-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples:spislave_test: Improve example #2820
Conversation
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Here's a breakdown of the missing information:
In short: The PR needs more details in the Summary, explicitly address each Impact category, and include actual testing logs with specific host/target information. Relying on a parallel PR for context isn't sufficient for a thorough review. |
29361b4
to
7531949
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @FelipeMdeO :-) Please fix code formatting, see: https://github.com/apache/nuttx-apps/actions/runs/11673965696/job/32505715960?pr=2820
@FelipeMdeO the coding style issues are just Long Lines, you can use the tools/checkpatch.sh -f path/to/file.c/h to show the lines with issues |
ping :-) |
7531949
to
b48fd82
Compare
Hello @cederom, sorry for delay. Code style issues solved. |
Thanks @FelipeMdeO for the updates :-) Please update git commit:
|
423b884
to
f899f67
Compare
Hello @acassis , done. |
Improve example, now it can receive commands / data from user; Fixed indentation issues. Signed-off-by: Felipe Moura <[email protected]>
f899f67
to
37ad23e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @FelipeMdeO :-)
Improve example, now it can receive data from user
Summary
Spislv example was improved. Now it can receive data from user. It follow spitool features standard:
This changes was done in parallel at apache/nuttx#14642. Both are tested together .
Impact
No Impact
Testing
This changes was done in parallel at apache/nuttx#14642. Both are tested together .