examples/amg88xx: fix kconfig #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix amg88xx kconfig EXAMPLES_AMG88XX_STACKSIZE option name add depends on SENSORS_AMG88XX to hide the example is the driver is not enabled
lupyuen
approved these changes
Feb 3, 2025
jerpelea
approved these changes
Feb 3, 2025
No worries |
simbit18
approved these changes
Feb 4, 2025
anchao
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small fix for my previous sloppy work on amg88xx example.
I forgot to add correct dependency for kconfig options.
Also, I've followed DTH driver as example, you can see that in the kconfig stack size option :D
Impact
In non-interactive build, some defines previously polluted the header file with no impact on build. Now is fixed.
In interactive build (running make menuconfig
or equivalent) the amg88xx example was visible without enabling the needed driverTesting
Manually.
Checked that the define is no longer included in the output header.
Check that the amg88xx example is not longer present in the menuconfig if the amg88xx driver is disabled.