Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging/embedlog: bump version to v0.7.2 #2996

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

mlyszczek
Copy link
Contributor

@mlyszczek mlyszczek commented Feb 14, 2025

Summary

Update embedlog to version v0.7.2

Impact

All apps using embedlog. This release only contains minor patches to remove compilation warnings.

Testing

  • local make check
============================================================================
Testsuite summary for embedlog 0.7.2
============================================================================
# TOTAL: 30884
# PASS:  30884
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
  • example and demo apps on nucleo hardware

@LuchianMihai
Copy link
Contributor

Can you please also remove line 150

CFLAGS += -DHAVE_TERMIOS_H

Since embedlog is no longer using termios?

@mlyszczek
Copy link
Contributor Author

Can you please also remove line 150

CFLAGS += -DHAVE_TERMIOS_H

Since embedlog is no longer using termios?

No, it's still being used internally, just nothing from it is being exported via API.

@mlyszczek
Copy link
Contributor Author

CFLAGS += -DHAVE_TERMIOS_H

This flag on its own won't increase code size unless you enable logging to serial output directly.

@LuchianMihai
Copy link
Contributor

Understood

Copy link

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mlyszczek :-)

Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a commit message explaining the reason for the update

v0.7.2 fixes few minor bug fixes during compilation

Signed-off-by: Michał Łyszczek <[email protected]>
@raiden00pl raiden00pl merged commit 0fb063f into apache:master Feb 20, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants