Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toywasm: bump to v66.0.0 #2998

Closed
wants to merge 2 commits into from
Closed

toywasm: bump to v66.0.0 #2998

wants to merge 2 commits into from

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Feb 16, 2025

Summary

toywasm: bump to v66.0.0

Impact

Testing

yamt added 2 commits February 16, 2025 15:18
```
REF=b0e100a4ebd666f02b2bb9222d402a9f399a740b ./regen.sh
```
Copy link

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yamt :-) Could you please sign the commits with git commit -s ? :-)

@yamt
Copy link
Contributor Author

yamt commented Feb 16, 2025

Thank you @yamt :-) Could you please sign the commits with git commit -s ? :-)

why?

@cederom
Copy link

cederom commented Feb 16, 2025

@cederom: Thank you @yamt :-) Could you please sign the commits with git commit -s ? :-)

@yamt: why?

So anyone looking at the local git log can see who was the commit author? See https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md :-)

The update is trivial and okay, just the commit signature missing, we requite that from everyone since 2024, thank you for your understanding @yamt :-)

@yamt
Copy link
Contributor Author

yamt commented Feb 17, 2025

@cederom: Thank you @yamt :-) Could you please sign the commits with git commit -s ? :-)

@yamt: why?

So anyone looking at the local git log can see who was the commit author? See https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md :-)

The update is trivial and okay, just the commit signature missing, we requite that from everyone since 2024, thank you for your understanding @yamt :-)

ok. i haven't noticed the change in CONTRIBUTING.md. i don't think it makes much sense as git commit log have enough author info, though.

@yamt
Copy link
Contributor Author

yamt commented Feb 17, 2025

i created a new PR #2999 because i noticed i have pushed the branch to a wrong repo.
i also added signed-off-by thing there.

@yamt yamt closed this Feb 17, 2025
@yamt yamt deleted the toywasm-66 branch February 17, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants