interpreters/quickjs/CMakeLists.txt: Sync of build Cmake with build Make #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupyuen
approved these changes
Feb 18, 2025
Setting the right version 2024-02-14 To avoid future breakage, used the URL with last commit ID Signed-off-by: simbit18 <[email protected]>
simbit18
force-pushed
the
simbit18-cmake
branch
from
86d2878 to
e604f5f
Compare
|
@lupyuen This does not depend on this PR :) https://github.com/apache/nuttx-apps/actions/runs/13389234727/job/37393046429?pr=3001#logs |
|
Yep I restarted the CI Jobs, GitHub CI got wonky talking to its own Docker Hub :-) |
raiden00pl
approved these changes
Feb 20, 2025
cederom
approved these changes
Feb 20, 2025
anchao
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Setting the right version 2024-02-14
To avoid future breakage, used the URL with last commit ID
PR #2993
Impact
Impact on user: NO.
Impact on build: YES.Prevents future breaks if the quickjs repository changes..
Impact on hardware: NO
Impact on documentation: NO
Impact on security: NO
Impact on compatibility: NO
Testing
Build it with:
cmake -B build -DBOARD_CONFIG=sim:quickjs -GNinja
cmake --build build