Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system/irtest/Make.defs: fixed the wrong path #3004

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

simbit18
Copy link
Contributor

Summary

fix this error
make[3] *** /nuttxspace/nuttx/apps/testing/irtest: No such file or directory. Stop.

same error with macOS on Nuttx mirror

make: *** /Users/runner/work/nuttx/nuttx/sources/apps/testing/irtest: No such file or directory.  Stop.
make[2]: *** [/Users/runner/work/nuttx/nuttx/sources/apps/testing/irtest_context] Error 2
make[2]: Target `context_all' not remade because of errors.
make[1]: *** [context] Error 2
make: *** [/Users/runner/work/nuttx/nuttx/sources/apps/.context] Error 2
make: Target `all' not remade because of errors.
/Users/runner/work/nuttx/nuttx/sources/nuttx/tools/testbuild.sh: line 385: /Users/runner/work/nuttx/nuttx/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory

https://github.com/NuttX/nuttx/actions/runs/13430411340/job/37521010985#logs

error due to this change
apps/testing: Move irtest/sensortest/resmonitor/monkey to apps/system #2976

Impact

Impact on user: NO.

Impact on build: YES. fix the build with Make

Impact on hardware: NO

Impact on documentation: NO

Impact on security: NO

Impact on compatibility: NO

Testing

Build it with:
./tools/configure.sh -l sim:rc
make -j

Without this PR

err_rc

With this PR

ok_rc

fix this error
make[3] *** /nuttxspace/nuttx/apps/testing/irtest: No such file or directory.  Stop.

error due to this change
apps/testing: Move irtest/sensortest/resmonitor/monkey to apps/system apache#2976

Signed-off-by: simbit18 <[email protected]>
@simbit18
Copy link
Contributor Author

simbit18 commented Feb 20, 2025

@lupyuen I ran a test on github and again, of course, the same error comes up

https://github.com/simbit18/nuttx_test_pr/actions/runs/13436257100/job/37539227553#logs

Also here as with sim:quickjs #2993

on the NuttX repository it is built correctly because on Ubuntu it uses Cmake

====================================================================================
Cmake in present: sim/rc
Configuration/Tool: sim/rc
2025-02-20 09:08:52
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Select HOST_LINUX=y
  Select HOST_X86_64=y
  Building NuttX...
====================================================================================

https://github.com/apache/nuttx/actions/runs/13431136480/job/37523189277#logs

Copy link

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @simbit18 :-)

@anchao anchao merged commit a8b8a73 into apache:master Feb 22, 2025
37 checks passed
@simbit18 simbit18 deleted the simbit18-rc branch February 24, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants