-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: move cmocka_fs to the new folder /basic #3011
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: tengshuangshuang <[email protected]>
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements as described. While it provides some information, it lacks crucial details. Here's a breakdown:
The PR description needs to be much more thorough to meet the NuttX requirements. Provide the missing context and details to make it clear why the change is necessary and that it has been properly validated. |
CI failed, restarted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @txy-21 :-)
- Please try to use relative paths (i.e.
apps/testing/fs/basic
) as/basic
means a location in root directory so totally different place :-P - I think the agreements was made before that test scenarios should be located in
apps/tests/
whileapps/testing/
was supposed to hold utilities and frameworks. Therefore target location should beapps/tests/cmocka/fs
instead. Other cmocka tests could be placed there in analog way with functional location names. I have asked for confirmation in the original tests reorganization thread The placement of cases under testing is a bit messy, and cases of the same type need to be merged #2931.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a commit message
Summary
testing: move cmocka_fs to the new folder /basic
Move the cmocka case folder under testsuites to testing/fs/basic
Impact
apps/testing/testsuites and apps/testing/fs/basic
Testing
ci test.