-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio: modify audio driver satisfy nuttx alsa #15657
Conversation
This PR is related to apache/nuttx-apps#2970 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @yangyalei amazing work porting ALSA to NuttX! :-)
ping @yangyalei |
Signed-off-by: yangyalei <[email protected]>
fbca2dc
to
9aa5ab7
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add commit description
@yangyalei very nice! Please rebase to fix the CI issue with xtensa |
Also please remove the Draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are remarks, lets wait until everything is solved out :-)
- git commit needs an update.
- this looks like small update, what are possible problems @xiaoxiang781216 ?
- my main concern is discussion from Add vela alsa lib interface nuttx-apps#2970 on ALSA inclusion in NuttX that would not violate GPL?
it isn't a new driver which implement a well defined interface(ioctl), but add a new interaction model with the userspace application. All this kind of improvement need review carefully to ensure the design and implementation is general enough for all drivers. |
Summary
Add vela alsa lib interface
Impact
nop
Testing
Use alsa lib interface play music in allwinnertech&BES platform