Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio: modify audio driver satisfy nuttx alsa #15657

Closed
wants to merge 1 commit into from

Conversation

yangyalei
Copy link

Summary

Add vela alsa lib interface

Impact

nop

Testing

Use alsa lib interface play music in allwinnertech&BES platform

@github-actions github-actions bot added Area: Audio Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. labels Jan 23, 2025
@yangyalei
Copy link
Author

This PR is related to apache/nuttx-apps#2970

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yangyalei amazing work porting ALSA to NuttX! :-)

@acassis
Copy link
Contributor

acassis commented Feb 12, 2025

ping @yangyalei

@yangyalei
Copy link
Author

ping @yangyalei

done

@xiaoxiang781216 xiaoxiang781216 marked this pull request as draft February 13, 2025 03:54
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add commit description

@acassis
Copy link
Contributor

acassis commented Feb 13, 2025

@yangyalei very nice! Please rebase to fix the CI issue with xtensa

@acassis
Copy link
Contributor

acassis commented Feb 13, 2025

Also please remove the Draft

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are remarks, lets wait until everything is solved out :-)

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Feb 14, 2025

There are remarks, lets wait until everything is solved out :-)

  • git commit needs an update.
  • this looks like small update, what are possible problems @xiaoxiang781216 ?

it isn't a new driver which implement a well defined interface(ioctl), but add a new interaction model with the userspace application. All this kind of improvement need review carefully to ensure the design and implementation is general enough for all drivers.
I change it to draft state, because I want the patch get the serious review before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Audio Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants