sensors/lsm6dso32: Fixed typo in device address registration. #15824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Sensors
acassis
approved these changes
Feb 12, 2025
acassis
requested review from
btashton,
liuguo09,
adamfeuer,
anchao,
yamt,
davids5,
cederom,
antmerlino,
yf13,
pussuw,
raiden00pl,
jerpelea,
lupyuen,
pkarashchenko,
xiaoxiang781216,
johannes-nivus,
masayuki2009,
tmedicci,
fjpanag,
GUIDINGLI and
hartmannathan
lupyuen
approved these changes
Feb 12, 2025
cederom
approved these changes
Feb 12, 2025
yf13
approved these changes
Feb 13, 2025
jerpelea
requested changes
Feb 13, 2025
The valid addresses should be 0x6a and 0x6b, not 0x6c. Now the device can be registered with the correct addresses without failing the assertion. Signed-off-by: Matteo Golin <[email protected]>
linguini1
force-pushed
the
lsm6dso32-typo
branch
from
0ad0083 to
390bd6a
Compare
jerpelea
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves issue where invalid address 0x6c was included instead of 0x6a.
Impact
Boards using 0x6a as the address will no longer receive a DEBUGASSERT failure when registering this driver.
Testing
Tests performed on InSpace's flight computer where the LSM6DSO32 IMU uses 0x6a as the address. This board is STM32 based. Here are the registration logs output: