-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/stm32: fix CAN bit timings for boards #15833
Conversation
boards/nucleo-f722ze: fix CAN bit timings, calculated with http://www.bittiming.can-wiki.info/ Signed-off-by: raiden00pl <[email protected]>
boards/nucleo-g431rb: fix CAN bit timings, calculated with https://phryniszak.github.io/stm32g-fdcan/ also update bit rate to 250000 so it's the same as for other stm32 boards Signed-off-by: raiden00pl <[email protected]>
boards/nucleo-f302r8: fix CAN bit timings, calculated with http://www.bittiming.can-wiki.info/ Signed-off-by: raiden00pl <[email protected]>
boards/nucleo-f446re: fix CAN bit timings, calculated with http://www.bittiming.can-wiki.info/ Signed-off-by: raiden00pl <[email protected]>
boards/b-g431b-esc1: fix CAN bit timings, calculated with https://phryniszak.github.io/stm32g-fdcan/ Signed-off-by: raiden00pl <[email protected]>
boards/nucleo-f303re: fix CAN bit timings, calculated with http://www.bittiming.can-wiki.info/ Signed-off-by: raiden00pl <[email protected]>
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, although it could be more thorough. Strengths:
Weaknesses:
Recommendation: While the core information is present, expanding on the weaknesses identified above would significantly improve the PR's clarity and ensure it fully meets the NuttX requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @raiden00pl :-) Also thank you for providing runtime verification logs :-)
Summary
Impact
all updated CAN configurations are now compatible with each other
Testing
different board combinations in the CAN network.
here example with
b-g431rb-esc
[1]nucleo-g431rb
[2] andnucleo-f302r8
: