Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/arm/stm32h750b-dk: adapt to stm32h750b-dk development board #16111

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

boards/arm/stm32h750b-dk: adapt to stm32h750b-dk development board #16111

wants to merge 3 commits into from
+3,393 −1

Conversation

liujp-arch
Copy link
Contributor

@liujp-arch liujp-arch commented Apr 2, 2025 •
edited
Loading

Summary

Adapt the software to the STM32H750B-DK development board

Impact

This change affects the build process and hardware support, ensuring the software runs correctly on the STM32H750B-DK.

Testing

The change was verified using a Linux host with an x86 CPU and GCC compiler. The target platform was the STM32H750B-DK board.

@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. labels Apr 2, 2025
@nuttxpr
Copy link

nuttxpr commented Apr 2, 2025

[Experimental Bot, please feedback here]

No. The provided information doesn't meet the NuttX PR requirements. It lacks crucial details:

  • Summary: Missing essential information about the specific change being made. "adapt to stm32h750b-dk development board" is far too vague. What exactly is being adapted? What files are modified? Is it a new driver, board port, configuration change, or something else entirely? There are no linked issues.
  • Impact: While mostly filled with "NO," adapting to a new board almost certainly has impacts on hardware, build process, and likely documentation. These need detailed explanations.
  • Testing: Completely empty. There are no details about the build host, target, or any testing logs demonstrating the change works.

This PR would likely be immediately rejected without substantially more information.

@lupyuen
Copy link
Member

lupyuen commented Apr 2, 2025

Sorry @liujp-arch: Could you fill in the "Summary", "Impact" and "Testing" sections in the PR? They are explained here: https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md

Please remember to fill in the Commit Description, just copy from the PR Summary. Thanks :-)

@liujp-arch liujp-arch force-pushed the dev_stm32h750 branch 2 times, most recently from 67dc578 to 26a41e5 Compare April 2, 2025 11:57
@raiden00pl
Copy link
Member

@liujp-arch please split the changes into 3 commits:

  1. arch/arm/stm32h7: add support for STM32H750B
  2. arch/arm/stm32h7: fixes for LTDC (please briefly describe what these changes do)
  3. boards/arm/stm32h7: add support for stm32h750b-dk board

@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture and removed Arch: arm Issues related to ARM (32-bit) architecture labels Apr 3, 2025
@liujp-arch
Copy link
Contributor Author

Sorry @liujp-arch: Could you fill in the "Summary", "Impact" and "Testing" sections in the PR? They are explained here: https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md

Please remember to fill in the Commit Description, just copy from the PR Summary. Thanks :-)

@liujp-arch please split the changes into 3 commits:

  1. arch/arm/stm32h7: add support for STM32H750B
  2. arch/arm/stm32h7: fixes for LTDC (please briefly describe what these changes do)
  3. boards/arm/stm32h7: add support for stm32h750b-dk board

@liujp-arch liujp-arch closed this Apr 3, 2025
@liujp-arch liujp-arch reopened this Apr 3, 2025
lupyuen
lupyuen requested changes Apr 3, 2025
View reviewed changes
Copy link
Member

@lupyuen lupyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @liujp-arch: The Commit Description is still missing for the commits below, could you copy from PR Summary? Thanks :-)

acassis
acassis approved these changes Apr 5, 2025
View reviewed changes
Copy link
Contributor

@acassis acassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just include the missing Commit Messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lupyuen lupyuen

@acassis acassis

@raiden00pl raiden00pl

@xiaoxiang781216 xiaoxiang781216

Assignees
No one assigned
Labels
Arch: arm Issues related to ARM (32-bit) architecture Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liujp-arch @nuttxpr @lupyuen @raiden00pl @acassis @xiaoxiang781216