Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtensa/esp32: Add option to disable raw esp-idf Wi-Fi log format #3267

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donghengqaz
Copy link
Contributor

Summary

Add option to disable raw esp-idf Wi-Fi log format.

Impact

Try to fix log prefix being mixed from NuttX log device: #3157.

Testing

@protobits
Copy link
Contributor

I don't think this is the right way to fix the issue. You are conditioning the printing to a very specific case which is not really useful
to have. The asprintf is also kind of a hack, involving an allocation/de-allocation every time.
As you mentioned, this problem is on the caller side on ESP32 wifi drivers and must be fixed there.

@donghengqaz
Copy link
Contributor Author

I don't think this is the right way to fix the issue. You are conditioning the printing to a very specific case which is not really useful
to have. The asprintf is also kind of a hack, involving an allocation/de-allocation every time.
As you mentioned, this problem is on the caller side on ESP32 wifi drivers and must be fixed there.

I agree with you, but our internal Wi-Fi team has a long plan, so I just can report this issue to them and when them select to do this is unknown, so I add this PR to hope this modification can do some help.

@protobits protobits marked this pull request as draft April 5, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants