arch/arm/samv7: use in application programming in EEFC code #7908
+41
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petro Karashchenko <[email protected]>
Signed-off-by: Petro Karashchenko <[email protected]>
pkarashchenko
force-pushed
the
samv7_iap
branch
from
8e81c58 to
2b3ed71
Compare
xiaoxiang781216
approved these changes
Dec 21, 2022
| uint32_t status; | ||
| irqstate_t flags; | ||
|
|
||
| flags = up_irq_save(); |
There was a problem hiding this comment.
why need up_irq_save here? line 76 is already an atomic operation.
There was a problem hiding this comment.
I will try to dump a ROM code to see. I'm expecting that IAP may execute multiple instructions and the flash re-programming requirement is that no code should be executed from flash during reprogramming, so up_irq_save is here to ensure there will be no interrupt during IAP execution.
Let me convert to draft while I'm figuring out all the details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use in application programming in EEFC code
Impact
SAMv7 based devices
Testing
Tested with MCUboot on custom board based on SAMe70