Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/can2 stm32l (WIP) #8460

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix/can2 stm32l (WIP) #8460

wants to merge 8 commits into from

Conversation

ASM3
Copy link
Contributor

@ASM3 ASM3 commented Feb 7, 2023

Summary

This PR fixes the CAN2 interface on the STM32L496

Impact

At the moment CAN2 does not work on the STM32L496. This fix should enable the CAN2 functionality.

Testing

Testing CAN2 on the STM32L496

@acassis
Copy link
Contributor

acassis commented Feb 10, 2023

@ASM3 I think you can remove the Draft, just use git rebase interactive to squash this empty commit: 70c9f6c You can get more info here: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request

ASM3 added 2 commits February 11, 2023 12:29
…STM32L4

Fix number of filter for the STM32L496 and add CAN registers for the STM32L4
@ASM3
Copy link
Contributor Author

ASM3 commented Feb 20, 2023

Removing draft status according to the request. The code is not fully tested.

@ASM3 ASM3 marked this pull request as ready for review February 20, 2023 13:50
@acassis
Copy link
Contributor

acassis commented Mar 24, 2023

Hi @ASM3 did you have the change to test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants